-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implement GeoTileGrid aggregation #3932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit adds the time zone information for a DateTime within a DateMath type, when the DateTimeKind is Local or Utc. This behaviour aligns 7.x with 6.x. Introduce StringBuilderCache for caching a StringBuilder per thread. Use of this can be extended in a later commit. Fixes #3899
This commit changes the HttpConnection to not set Content on HttpRequestMessage when there is no PostData. The check is performed inside of Request and RequestAsync to avoid creating any content instance and allocations. Pass RequestData through to _onStreamAvailable delegates so that HttpCompression, ConnectionSettings and PostData can be accessed on the passed instance. Fixes #3907 (cherry picked from commit 90c2bf7)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 left some small comments
src/Nest/Aggregations/Bucket/GeoTileGrid/GeoTileGridAggregation.cs
Outdated
Show resolved
Hide resolved
src/Nest/Aggregations/Bucket/GeoTileGrid/GeoTileGridAggregation.cs
Outdated
Show resolved
Hide resolved
src/Nest/Aggregations/Bucket/GeoTileGrid/GeoTileGridAggregation.cs
Outdated
Show resolved
Hide resolved
src/Nest/Aggregations/Bucket/GeoTileGrid/GeoTileGridAggregation.cs
Outdated
Show resolved
Hide resolved
Can this be based against master, then ported to 7.1? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome left a small nitpick
src/Tests/Tests/Aggregations/Bucket/GeoHashTile/GeoTileGridAggregationUsageTests.cs
Show resolved
Hide resolved
Aligning precision summaries with advice on this page: https://wiki.openstreetmap.org/wiki/Zoom_levels |
Implement GeoTileGrid aggregation
Implement GeoTileGrid aggregation
Implement GeoTileGrid aggregation
No description provided.