Skip to content

Add track_total_hits to search request body #3917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2019
Merged

Add track_total_hits to search request body #3917

merged 1 commit into from
Jul 9, 2019

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jul 4, 2019

This commit removes track_total_hits as a query string parameter on a search request and instead defines it in the body, allowing track_total_hits to work with individual search requests in multi search API.

Closes #3906

@russcam russcam mentioned this pull request Jul 4, 2019
Closed
codebrain
codebrain approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam
Add track_total_hits to search request body
8e85395 
This commit removes track_total_hits as a query string parameter on a search request and instead defines it in the body, allowing track_total_hits to work with individual search requests in multi search API.

Closes #3906
@russcam
Copy link
Contributor Author

russcam commented Jul 8, 2019

rebased on top of master and force pushed, because the failing CI tests I don't believe are related to this change. Will wait for these to finish running before merging

@russcam russcam merged commit 75317ec into master Jul 9, 2019
russcam added a commit that referenced this pull request Jul 9, 2019
@russcam
Add track_total_hits to search request body (#3917)
7b814e0 
This commit removes track_total_hits as a query string parameter on a search request and instead defines it in the body, allowing track_total_hits to work with individual search requests in multi search API.

Closes #3906

(cherry picked from commit 75317ec)
@russcam russcam deleted the fix/3906 branch July 9, 2019 04:03
russcam added a commit that referenced this pull request Jul 18, 2019
@russcam
Add track_total_hits to search request body (#3917)
b8dd09b 
This commit removes track_total_hits as a query string parameter on a search request and instead defines it in the body, allowing track_total_hits to work with individual search requests in multi search API.

Closes #3906

(cherry picked from commit 75317ec)
codebrain pushed a commit that referenced this pull request Jul 19, 2019
@russcam
Add track_total_hits to search request body (#3917)
25d4c04 
This commit removes track_total_hits as a query string parameter on a search request and instead defines it in the body, allowing track_total_hits to work with individual search requests in multi search API.

Closes #3906

(cherry picked from commit 75317ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebrain codebrain codebrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TrackTotalHits is ignored during MultiSearch call
2 participants
@russcam @codebrain