Split JSON generation from Elasticsearch sending #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to send metrics using the same pipeline I have for logs (Kafka + Logstash + Elasticsearch) and not directly to Elasticsearch.
I've split the ElasticsearchReporter class in two: BaseJsonReporter produces metrics in JSON format and ElasticsearchReporter send them Elasticsearch.
I wrote a JsonFileReporter to show I can output metrics to something else using the same format. These files could be read by FileBeat.
I was forced to had the metric type in the JSON documents.
I plan to write a KafkaReporter for my own needs similar to JsonFileReporter.
I admit this code is far from being production grade, it's more a proof of concept.
Do you think it's a good idea? And provided I take time to improve code, would you accept such a PR?