onSuccess function for bulk helper #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For #2090 Includes refactor of the tryBulk result processing code, to make iterating over bulk response data easier to understand.
Page not yet published, breaking docs build.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Bulk helper onSuccess callback For #2090 Includes refactor of the tryBulk result processing code, to make iterating over bulk response data easier to understand. * Add onSuccess tests for each datasource type * Cleanup, additional comments * Add documentation for onSuccess callback * Update changelog * Drop link to 8.14 release notes. Page not yet published, breaking docs build. (cherry picked from commit 4aa00e0)
JoshMock
added
the
apply-to-serverless
JoshMock
added a commit
to elastic/elasticsearch-serverless-js
that referenced
this pull request
Apr 3, 2024
JoshMock
added a commit
to elastic/elasticsearch-serverless-js
that referenced
this pull request
Apr 3, 2024
JoshMock
added a commit
to elastic/elasticsearch-serverless-js
that referenced
this pull request
Apr 3, 2024
Applies patches from elastic/elasticsearch-js#2199 and elastic/elasticsearch-js#2027, adding support for an onSuccess callback and fixing a bug that would cause the helper to hang when the flushInterval was lower than the request timeout. --------- Co-authored-by: JoshMock <160161+JoshMock@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2090
Includes refactor of the
tryBulkresult processing code, to make iterating over bulk response data easier to understand.