Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isHttpConnection check #1526

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Fix isHttpConnection check #1526

merged 2 commits into from
Aug 20, 2021

Conversation

delvedor
Copy link
Member

As titled.

@delvedor delvedor requested a review from azasypkin August 20, 2021 08:38
@azasypkin
Copy link
Member

ACK: reviewing....

azasypkin
azasypkin approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally with Kibana - everything works as expected, thanks for the quick turnaround here!

@delvedor delvedor merged commit a0dcace into master Aug 20, 2021
@delvedor delvedor deleted the fix-http-check branch August 20, 2021 10:40
github-actions bot pushed a commit that referenced this pull request Aug 20, 2021
@delvedor @github-actions
Fix isHttpConnection check (#1526)
be5e29f
@github-actions github-actions bot mentioned this pull request Aug 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
backport 7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delvedor @azasypkin