Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop node v10 support #1471

Merged
merged 4 commits into from
May 20, 2021
Merged

Drop node v10 support #1471

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c880cb1
Drop node v10
delvedor May 20, 2021
d772a62
Updated deps
delvedor May 20, 2021
916806b
Remove pump dependency
delvedor May 20, 2021
a7901b3
Updated CI conf
delvedor May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Drop node v10
  • Loading branch information
@delvedor
delvedor committed May 20, 2021
commit c880cb1ee8c75f749a060193308cb3b89916425c
11 changes: 0 additions & 11 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@

'use strict'

const nodeMajor = Number(process.versions.node.split('.')[0])

const { EventEmitter } = require('events')
const { URL } = require('url')
const debug = require('debug')('elasticsearch')
Expand All @@ -47,15 +45,6 @@ const kEventEmitter = Symbol('elasticsearchjs-event-emitter')

const ESAPI = require('./api')

/* istanbul ignore next */
if (nodeMajor >= 10 && nodeMajor < 12) {
process.emitWarning('You are using a version of Node.js that will reach EOL in April 2021. ' +
'The support for this version will be dropped in 7.13. ' +
'Please refer to https://ela.st/nodejs-support for additional information.',
'DeprecationWarning'
)
}

class Client extends ESAPI {
constructor (opts = {}) {
super({ ConfigurationError })
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
"url": "https://github.com/elastic/elasticsearch-js/issues"
},
"engines": {
"node": ">=10"
"node": ">=12"
},
"tsd": {
"directory": "test/types"
Expand Down