Skip to content

Disable client Helpers in Node.js < 10. #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2020
Merged

Disable client Helpers in Node.js < 10. #1194

merged 3 commits into from
May 14, 2020

Conversation

delvedor
Copy link
Member

@delvedor delvedor commented May 14, 2020

As titled.

Fixes: #1193

@delvedor delvedor merged commit 22de806 into master May 14, 2020
@delvedor delvedor deleted the fix-1193 branch May 14, 2020 14:03
@github-actions
Copy link
Contributor

The backport to 7.x failed:

The process 'git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.x 7.x
# Navigate to the new working tree
cd .worktrees/backport-7.x
# Create a new branch
git switch --create backport-1194-to-7.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 22de806b67f18b11f09d96db4ec7cb34ccad9355
# Push it to GitHub
git push --set-upstream origin backport-1194-to-7.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.x

Then, create a pull request where the base branch is 7.x and the compare/head branch is backport-1194-to-7.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change on older node versions
1 participant