-
Notifications
You must be signed in to change notification settings - Fork 993
Improving documentation about es.read.fields.include, and fixing a related bug #1822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is confusing, and easiest for me to think about using concrete examples. I added them in the integration tests in this PR, but it's probably easier to see without code. Using the schema from #1784:
Say I have this data in elasticsearch:
If I leave "es.read.fields.include" unset or if I set it to "features.hashtags.*" I get
If I set "es.read.fields.include" to "features.hashtags" I get
If I set "es.read.fields.include" to "features.hashtags.text" I get
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for clarifying these.
The documentation for es.read.fields.include left room for confusion. Also the bevaior was different between spark 1,
spark 2, and spark 3 -- setting "es.read.fields.include" to part of a hierarchy caused a NullPointerException in spark 1
and spark 2.
Closes #1784