Closing RestRepository to avoid a connection leak #1781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems a little wrong to have ScrollQuery closing an object that it did not open. But it is only used in this one place, and it is appropriate for the RestRepository to be closed in this case. So it's probably not worth doing something more complex (like adding the machinery to have a listener called from ScrollQuery's close). |
masseyke
added a commit
to masseyke/elasticsearch-hadoop
that referenced
this pull request
Oct 25, 2021
This commit closes the RestRepository that is sent to the ScrollQuery constructor to avoid leaking connections to Elasticsearch when many fast scrolls are called in a tight loop. Closes elastic#1212
masseyke
added a commit
that referenced
this pull request
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit closes the RestRepository that is sent to the ScrollQuery constructor to avoid leaking connections to
Elasticsearch when many fast scrolls are called in a tight loop.
Closes #1212