resolve saveToEs saves case classes fields with NULL values #998 #1478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucebert
changed the title
|
It is configurable with ES_SPARK_DATAFRAME_WRITE_NULL_VALUES parameter (
es.spark.dataframe.write.null).
The default value is false, it has to be set to true in order to index null values
Le jeu. 21 mai 2020 à 19:43, rohitgcs <notifications@github.com> a écrit :
… Can this be configurable? If I want nulls to show - then this PR removes
it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1478 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJKCKP2ZKIMAYFSKCHGTDHLRSVR43ANCNFSM4NC4DKCQ>
.
|
|
Hi @lucebert. Sorry for the very long delay. Thanks for the PR, and especially the tests. If you are still around I would like to get this merged in. It looks pretty good to me but now has merge conflicts that need to be cleared up before it can be merged. |
masseyke
reviewed
Dec 20, 2021
spark/core/main/scala/org/elasticsearch/spark/serialization/ScalaValueWriter.scala
Outdated
Show resolved
Hide resolved
|
@lucebert do you want to merge this? I think you'll have permissions now. If not, I can merge it. |
|
@masseyke Thanks for the review. I don't seem to be able to merge, so you can do it 👍 |
masseyke
pushed a commit
to masseyke/elasticsearch-hadoop
that referenced
this pull request
Jan 6, 2022
… (elastic#1478) This PR fix the Scala Writer when it processes case classes with null fields. Closes elastic#998
masseyke
pushed a commit
to masseyke/elasticsearch-hadoop
that referenced
this pull request
Jan 6, 2022
… (elastic#1478) This PR fix the Scala Writer when it processes case classes with null fields. Closes elastic#998
masseyke
added a commit
that referenced
this pull request
Jan 6, 2022
masseyke
added a commit
that referenced
this pull request
Jan 6, 2022
This was referenced Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the Scala Writer when it processes case classes with null fields.
Correction about issue #998