Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes unnecessary require base64 found thanks to warning in Ruby 3.3 #74

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Removes unnecessary require base64 found thanks to warning in Ruby 3.3 #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c58927c
[CI] Updates Stack and Ruby version in test matrices
picandocodigo Jan 24, 2024
da81b44
Removes unnecessary require base64 found thanks to warning in Ruby 3.3
picandocodigo Jan 24, 2024
cf9d311
Bumps version to 8.3.1, updates CHANGELOG
picandocodigo Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/otel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ['3.2', 'jruby-9.4']
es_version: ['8.9-SNAPSHOT']
ruby: ['3.3', 'jruby-9.4']
es_version: ['8.12-SNAPSHOT']
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [ '3.0', '3.1', '3.2', 'jruby-9.3' ]
es_version: ['8.9-SNAPSHOT']
ruby: [ '3.0', '3.1', '3.2', '3.3', 'jruby-9.3' ]
es_version: ['8.12-SNAPSHOT']
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 8.3.1

Tested versions of Ruby: (MRI) 3.0, 3.1, 3.2, 3.3, JRuby 9.3 and JRuby 9.4

- Removes unneccessary `require 'base64'` found thanks to warning in Ruby 3.3. So this removes the warning too if you were using Ruby 3.3.

## 8.3.0

Tested versions of Ruby: (MRI) 3.0, 3.1, 3.2, JRuby 9.3 and JRuby 9.4
Expand Down
1 change: 0 additions & 1 deletion lib/elastic/transport/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
# specific language governing permissions and limitations
# under the License.

require 'base64'
require 'elastic/transport/meta_header'

module Elastic
Expand Down
2 changes: 0 additions & 2 deletions lib/elastic/transport/meta_header.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
# specific language governing permissions and limitations
# under the License.

require 'base64'

module Elastic
module Transport
# Methods for the Elastic meta header used by Cloud.
Expand Down
2 changes: 1 addition & 1 deletion lib/elastic/transport/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@

module Elastic
module Transport
VERSION = '8.3.0'.freeze
VERSION = '8.3.1'.freeze
end
end
Loading