-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updatecli: pass the username to fix the issue with auth #2009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! Could we also add github/workflows/values.d
to the list of pull_request
trigger paths in
pull_request: |
- name: Update Package Registry version | ||
# --experimental needed for commitusingapi option. | ||
run: updatecli --experimental ${{ env.UPDATECLI_ACTION }} --config .github/workflows/updatecli.d/bump-package-registry-version.yml --values .github/workflows/updatecli.d/scm.yml | ||
run: updatecli --experimental ${{ env.UPDATECLI_ACTION }} --config .github/workflows/updatecli --values .github/workflows/updatecli/values.d/scm.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, does it work the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does run all the defined pipelines in the folder; see:
💚 Build Succeeded
History
cc @v1v |
Applying these changes to the integrations repo in elastic/integrations#10739 |
What
Pin version
v2.64.0
Set
username
to solve the issues with the authentication needed.Simplify GitHub action to use a folder with all the pipelines
Restructure the folder layout for the updatecli, updatecli.d for pipelines and values.d for configuration files.
Why
Use the latest version and fix the issue when using a version over 2.62.0
Tests
See https://github.com/elastic/elastic-package/actions/runs/10299711920/job/28507533818