Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatecli: pass the username to fix the issue with auth #2009

Merged
merged 6 commits into from
Aug 8, 2024
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Aug 8, 2024

What

Pin version v2.64.0
Set username to solve the issues with the authentication needed.
Simplify GitHub action to use a folder with all the pipelines
Restructure the folder layout for the updatecli, updatecli.d for pipelines and values.d for configuration files.

Why

Use the latest version and fix the issue when using a version over 2.62.0

Tests

See https://github.com/elastic/elastic-package/actions/runs/10299711920/job/28507533818

@v1v v1v requested a review from a team as a code owner August 8, 2024 09:41
@v1v v1v requested a review from jsoriano August 8, 2024 09:41
@v1v v1v self-assigned this Aug 8, 2024
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Could we also add github/workflows/values.d to the list of pull_request trigger paths in

?

- name: Update Package Registry version
# --experimental needed for commitusingapi option.
run: updatecli --experimental ${{ env.UPDATECLI_ACTION }} --config .github/workflows/updatecli.d/bump-package-registry-version.yml --values .github/workflows/updatecli.d/scm.yml
run: updatecli --experimental ${{ env.UPDATECLI_ACTION }} --config .github/workflows/updatecli --values .github/workflows/updatecli/values.d/scm.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, does it work the same?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v1v v1v enabled auto-merge (squash) August 8, 2024 11:30
@v1v v1v requested a review from jsoriano August 8, 2024 11:30
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @v1v

@v1v v1v merged commit 41a4185 into main Aug 8, 2024
4 checks passed
@v1v v1v deleted the feature/updatecli branch August 8, 2024 12:23
@jsoriano
Copy link
Member

jsoriano commented Aug 8, 2024

Applying these changes to the integrations repo in elastic/integrations#10739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants