fix: improve line join rendering #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
==========================================
+ Coverage 70.09% 70.63% +0.54%
==========================================
Files 341 357 +16
Lines 11014 11318 +304
Branches 2388 2412 +24
==========================================
+ Hits 7720 7995 +275
- Misses 3280 3303 +23
- Partials 14 20 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rshen91
approved these changes
Dec 1, 2020
nickofthyme
approved these changes
Dec 1, 2020
markov00
pushed a commit
that referenced
this pull request
Dec 4, 2020
# [24.3.0](v24.2.0...v24.3.0) (2020-12-04) ### Bug Fixes * **highlighter:** show default highlighted radius with hidden dots ([#926](#926)) ([8b167a4](8b167a4)), closes [#679](#679) * **xy_chart:** improve line joins rendering ([#920](#920)) ([ec8041a](ec8041a)) * point highlight based on geom position and transform ([#934](#934)) ([7198b5d](7198b5d)) ### Features * allow no results component, don't require series ([#936](#936)) ([4766c23](4766c23)) * improved domain error handling ([#933](#933)) ([94534a5](94534a5))
|
🎉 This PR is included in version 24.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [24.3.0](elastic/elastic-charts@v24.2.0...v24.3.0) (2020-12-04) ### Bug Fixes * **highlighter:** show default highlighted radius with hidden dots ([opensearch-project#926](elastic/elastic-charts#926)) ([351c20c](elastic/elastic-charts@351c20c)), closes [opensearch-project#679](elastic/elastic-charts#679) * **xy_chart:** improve line joins rendering ([opensearch-project#920](elastic/elastic-charts#920)) ([9a6771c](elastic/elastic-charts@9a6771c)) * point highlight based on geom position and transform ([opensearch-project#934](elastic/elastic-charts#934)) ([196ee8d](elastic/elastic-charts@196ee8d)) ### Features * allow no results component, don't require series ([opensearch-project#936](elastic/elastic-charts#936)) ([6be5c8b](elastic/elastic-charts@6be5c8b)) * improved domain error handling ([opensearch-project#933](elastic/elastic-charts#933)) ([f480054](elastic/elastic-charts@f480054))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR change the lineJoin property used when rendering lines to
roundto avoid spikes with very acute anglesFrom:
To:
The spike effect mostly visible when using a line with a
strokeWidthgreater than 1 and the artifact created distorts also the actual chart reading: