-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: IE11 smoke tests #543
chore: IE11 smoke tests #543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Not sure how to test this locally with IE11.
browsers/browsers.test.ts
Outdated
await driver.quit(); | ||
}); | ||
|
||
test('Google', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update test naming?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solved
@nickofthyme I know, I think the only way to test it is using virtualbox and a removeWebDriver: https://stackoverflow.com/questions/12380454/how-to-setup-ie-webdriver-on-a-remote-box |
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
=======================================
Coverage 75.88% 75.88%
=======================================
Files 194 194
Lines 5879 5879
Branches 1143 1099 -44
=======================================
Hits 4461 4461
Misses 1401 1401
Partials 17 17
Continue to review full report at Codecov.
|
🎉 This PR is included in version 17.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 17.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
This PR add a simple smoke test for IE11.
The test runs in a GH action, attaching a selenium driver/ webDriver to IE11 and checking if at least one
echChart
element is present on the page of the current Playground.The test is very basic but helps at the moment to check if we have added an incompatible IE11 library that prevent the chart from rendering (usually because the bundle can't be evaluated by IE11).
In this PR, the action is run on the fork repo (see https://github.com/markov00/elastic-charts/actions?query=workflow%3A%22Smoke+Tests%22)
I'm pretty sure that, after we merged this PR, the Action will run from the elastic repo
For reference: https://dev.to/mizchi/run-crossbrowser-e2e-testing-on-github-actions-671
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any consumer-facing exports were added tosrc/index.ts
(and stories only import from../src
except for test data & storybook)[ ] Proper documentation or storybook story was added for features that require explanation or tutorials