Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: IE11 smoke tests #543

Merged
merged 10 commits into from
Feb 10, 2020

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Feb 10, 2020

Summary

This PR add a simple smoke test for IE11.
The test runs in a GH action, attaching a selenium driver/ webDriver to IE11 and checking if at least one echChart element is present on the page of the current Playground.

The test is very basic but helps at the moment to check if we have added an incompatible IE11 library that prevent the chart from rendering (usually because the bundle can't be evaluated by IE11).

In this PR, the action is run on the fork repo (see https://github.com/markov00/elastic-charts/actions?query=workflow%3A%22Smoke+Tests%22)
I'm pretty sure that, after we merged this PR, the Action will run from the elastic repo

For reference: https://dev.to/mizchi/run-crossbrowser-e2e-testing-on-github-actions-671

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • [ ] Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility, including a check against IE11
  • [ ] Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

@markov00 markov00 added the wip work in progress label Feb 10, 2020
@markov00 markov00 added chore and removed wip work in progress labels Feb 10, 2020
@markov00 markov00 requested a review from nickofthyme February 10, 2020 15:13
Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Not sure how to test this locally with IE11.

await driver.quit();
});

test('Google', async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update test naming?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solved

@markov00
Copy link
Member Author

LGTM, Not sure how to test this locally with IE11.

@nickofthyme I know, I think the only way to test it is using virtualbox and a removeWebDriver: https://stackoverflow.com/questions/12380454/how-to-setup-ie-webdriver-on-a-remote-box
but for now I think the we can just test it on the action and manual testing in IE11 as we are doing already

@elastic elastic deleted a comment from robgil Feb 10, 2020
@elastic elastic deleted a comment from codecov-io Feb 10, 2020
@elastic elastic deleted a comment from robgil Feb 10, 2020
@elastic elastic deleted a comment from codecov-io Feb 10, 2020
@elastic elastic deleted a comment from robgil Feb 10, 2020
@elastic elastic deleted a comment from codecov-io Feb 10, 2020
@elastic elastic deleted a comment from robgil Feb 10, 2020
@elastic elastic deleted a comment from codecov-io Feb 10, 2020
@elastic elastic deleted a comment from robgil Feb 10, 2020
@elastic elastic deleted a comment from codecov-io Feb 10, 2020
@codecov-io
Copy link

codecov-io commented Feb 10, 2020

Codecov Report

Merging #543 into master will not change coverage.
The diff coverage is 91.3%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #543   +/-   ##
=======================================
  Coverage   75.88%   75.88%           
=======================================
  Files         194      194           
  Lines        5879     5879           
  Branches     1143     1099   -44     
=======================================
  Hits         4461     4461           
  Misses       1401     1401           
  Partials       17       17
Impacted Files Coverage Δ
src/components/legend/legend_item.tsx 100% <100%> (ø) ⬆️
..._types/xy_chart/renderer/canvas/bar_geometries.tsx 28.94% <100%> (ø) ⬆️
...types/xy_chart/renderer/canvas/rect_annotation.tsx 42.85% <100%> (ø) ⬆️
...types/xy_chart/renderer/canvas/line_geometries.tsx 27.77% <100%> (ø) ⬆️
src/chart_types/xy_chart/renderer/canvas/axis.tsx 21.6% <100%> (ø) ⬆️
src/chart_types/xy_chart/renderer/canvas/grid.tsx 48.64% <100%> (ø) ⬆️
src/components/icons/icon.tsx 100% <100%> (ø) ⬆️
...hart_types/xy_chart/renderer/canvas/bar_values.tsx 42.5% <100%> (ø) ⬆️
...types/xy_chart/renderer/canvas/line_annotation.tsx 35.29% <100%> (ø) ⬆️
src/components/chart_container.tsx 56.45% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8965fa8...bd772c1. Read the comment docs.

@markov00 markov00 merged commit 0bc617a into elastic:master Feb 10, 2020
@markov00 markov00 deleted the 2020-02-10_gh-actions-ie11-snapshot branch February 10, 2020 16:40
@markov00
Copy link
Member Author

🎉 This PR is included in version 17.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Feb 12, 2020
@markov00
Copy link
Member Author

🎉 This PR is included in version 17.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants