fix(metric): add option to set empty cell background color #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
added
:styling
nickofthyme
changed the title
|
buildkite update screenshots |
nickofthyme
added a commit
to nickofthyme/elastic-charts
that referenced
this pull request
Nov 19, 2023
nickofthyme
pushed a commit
that referenced
this pull request
Nov 20, 2023
# [61.1.0](v61.0.0...v61.1.0) (2023-11-20) ### Bug Fixes * **deps:** update dependency @elastic/eui to v91 ([#2233](#2233)) ([e89f623](e89f623)) * **metric:** add option to set empty cell background color ([#2247](#2247)) ([6a9fb86](6a9fb86)) * **metric:** background color for bar with interactions ([#2248](#2248)) ([dcb56fa](dcb56fa)) ### Features * **bullet:** improve header layout and positioning ([#2243](#2243)) ([b3a95d2](b3a95d2)) * **bullet:** new design style and implementation ([#2156](#2156)) ([fca6cdd](fca6cdd))
nickofthyme
pushed a commit
that referenced
this pull request
Nov 20, 2023
## [61.0.1](v61.0.0...v61.0.1) (2023-11-20) ### Bug Fixes * **metric:** add option to set empty cell background color ([#2247](#2247)) [61.0.x] ([#2250](#2250)) ([fe3aefe](fe3aefe)) * **metric:** background color for bar with interactions ([#2248](#2248)) [61.0.x] ([#2249](#2249)) ([4483606](4483606))
nickofthyme
added a commit
to nickofthyme/elastic-charts
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds option to
Theme.metric.emptyBackgroundto set the color of empty backgrounds.Details
In updating chart in kibana following changes in #2184 I noticed a difference in the empty/missing cells in the grid form. This was not presented in our VRT screenshots because we use the same background color for the chart as the page which Lens does not. Also we pass the real background color where Lens was passing
transparentwhich would not enable color blending as desired in #2184. Thus in order to provide a way to color these empty/missing cells I added a theme option to set the background color.Checklist
:xy,:partition):interactions,:axis)packages/charts/src/index.tslightanddarkthemes