fix(metric): fix rendering artifact #2218
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes minor rendering artifact in Chrome introduced in #2184
Details
With the changes from #2184 we introduced support for transparent colors. This change would have overlapping colors on the trend line metric causing blended colors. To prevent this we split the top and bottom half of the sparkline in two so the shapes rendered independently directly on the metric background.
Doing this caused a slight white sliver to be rendered between the two halves for colors with hight constant to the background, even with
strokeWidth
set to0
.To fix this we render a thin line along the spark line to fill this render defect without making the line too thick where a transparent color overlap would create a noticeable line.
Checklist
:xy
,:partition
)light
anddark
themes