Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: updates and tweaks #2109

Merged
merged 27 commits into from
Jul 18, 2023
Merged

ci: updates and tweaks #2109

merged 27 commits into from
Jul 18, 2023

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Jul 17, 2023 •
edited
Loading

Summary

This PR adds some updates the our buildkite ci, inclluding:

  • Remove deployment statuses, per request via slack
  • Deploy storybook and e2e_server prior to playwright completion.
  • Only run vrt update on commit push. Avoids running update on every successive buildkite test this comment.
  • Fix git mirror issues related to fix Buildkite failing on all EUI upgrades #2034. Wrong branch was being passed to buildkite see 84d0b95.
  • Add better error handling and messaging, see example below.
image

Issues

fixes #2034

nickofthyme added 27 commits July 17, 2023 13:17
@nickofthyme
ci: refactor deplyment status updates for PRs
0cc88a0
@nickofthyme
fix: undefined commit error
93173db
@nickofthyme
fix: undefined edges error
081aae4
@nickofthyme
chore: cleanup code logic
21e0aaf
@nickofthyme
fix: firebase executable
61d2021
@nickofthyme
fix: change firebase executable
14468ea
@nickofthyme
chore: catch error not finding channel
957967e
@nickofthyme
chore: add pre_deploy step, skip exec failure statuses
f89180f
@nickofthyme
chore: add pre deploy flag
5f1a020
@nickofthyme
chore: add 404 for e2e-report for pre deploy step
cf2d27c
@nickofthyme
fix: static 404 file path
94b4d14
@nickofthyme
fix: make 404 directory
ebe57bb
@nickofthyme
fix: prettier errors and ignore html files in eslint
5e9157d
@nickofthyme
fix: pass updateDeployment options to getComment
365b193
@nickofthyme
fix: no intermediate status needed for comment
36d3930
@nickofthyme
fix: git-mirror issues with build triggers
6647fac
@nickofthyme
fix: buildkite cleanup
b8154f3 
- delete firebase deployment on close/merge of pr
- extends expiration from 7 days to 4 weeks
@nickofthyme
test error handling in exec
2a1a097
@nickofthyme
add better error messaging
bb242bf
@nickofthyme
fix error messages
26390b2
@nickofthyme
fix: prettier errors
8f6f1e1
@nickofthyme
update error message
c1008d9
@nickofthyme
fix: firebase expires input
e580d7f
@nickofthyme
fix firebase expire duration again!
ce90509
@nickofthyme
fix: prettier errors
4266573
@nickofthyme
fix pre deployment issue
7a00028
@nickofthyme
Merge branch 'main' into ci-tweaks
fcc59e6
@nickofthyme nickofthyme added visual testing issues related to visual testing :ci internal Internal changes with no external impact labels Jul 17, 2023
@nickofthyme nickofthyme marked this pull request as ready for review July 18, 2023 05:03
@nickofthyme nickofthyme changed the title ci: updates and tweaks ci(buildkite): updates and improvements to flow Jul 18, 2023
@nickofthyme nickofthyme merged commit 250ca75 into elastic:main Jul 18, 2023
@nickofthyme nickofthyme deleted the ci-tweaks branch July 18, 2023 05:05
@nickofthyme nickofthyme changed the title ci(buildkite): updates and improvements to flow ci: updates and tweaks Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:ci internal Internal changes with no external impact visual testing issues related to visual testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buildkite failing on all EUI upgrades
1 participant
@nickofthyme