Skip to content

Conversation

markov00
Copy link
Member

Summary

I've moved the storybook icon to be picked up as a favicon instead of including it into the head tag.
This just prevents Storybook from loading the logo on every page.

I've also changed the brandImage to use our logo
Screenshot 2021-02-10 at 11 11 03

@codecov-io
Copy link

codecov-io commented Feb 10, 2021

Codecov Report

Merging #1022 (87c997d) into master (9f9e5c2) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
- Coverage   72.53%   72.52%   -0.01%     
==========================================
  Files         363      363              
  Lines       11184    11183       -1     
  Branches     2437     2436       -1     
==========================================
- Hits         8112     8111       -1     
  Misses       3058     3058              
  Partials       14       14              
Flag Coverage Δ
unittests 72.52% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/chart_types/xy_chart/renderer/dom/crosshair.tsx 70.17% <0.00%> (-0.52%) ⬇️
src/components/brush/brush.tsx 78.18% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f9e5c2...73616f1. Read the comment docs.

Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@rshen91 rshen91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥳 🎉

@markov00 markov00 merged commit 7a5a410 into elastic:master Feb 11, 2021
@markov00 markov00 deleted the 2021_02_10-logo branch February 11, 2021 13:42
@markov00
Copy link
Member Author

🎉 This PR is included in version 24.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants