-
Notifications
You must be signed in to change notification settings - Fork 198
[main][Automation] Update versions #8760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These files are used for picking the starting (pre-upgrade) or ending (post-upgrade) agent versions in upgrade integration tests. The content is based on responses from https://www.elastic.co/api/product_versions and https://snapshots.elastic.co The current update is generated based on the following requirements: Package version: 9.2.0 ```json { "UpgradeToVersion": "9.2.0", "CurrentMajors": 1, "PreviousMajors": 1, "PreviousMinors": 2, "SnapshotBranches": [ "9.1", "9.0", "7.17" ] } ```
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
1 similar comment
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
| testVersions: | ||
| - 9.0.3 | ||
| - 9.0.3-SNAPSHOT | ||
| - 8.19.0-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok everything is correct here except this one 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I just realised that this is correct indeed, according to the code this is what we are after
Lines 2422 to 2435 in 0340e6b
| maxSnapshots := 3 | |
| branches, err := git.GetReleaseBranches(ctx) | |
| if err != nil { | |
| return fmt.Errorf("failed to list release branches: %w", err) | |
| } | |
| // -1 because we manually add 7.17 below | |
| if len(branches) > maxSnapshots-1 { | |
| branches = branches[:maxSnapshots-1] | |
| } | |
| // it's not a part of this repository, cannot be retrieved with `GetReleaseBranches` | |
| branches = append(branches, "7.17") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to do an exception for 8.19 in the same way we are doing for 7.17 as it will last for a long time.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay that makes sense, let's keep this PR at bay then, and I am gonna open a PR with the 8.19 expection just for the 9.x branches 🙂
|
@ycombinator also in this PR |
|
💚 Build Succeeded
|
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
closing as this one #8761 got merged in main |





These files are used for picking the starting (pre-upgrade) or ending (post-upgrade) agent versions in upgrade integration tests.
The content is based on responses from https://www.elastic.co/api/product_versions and https://snapshots.elastic.co
The current update is generated based on the following requirements:
Package version: 9.2.0
{ "UpgradeToVersion": "9.2.0", "CurrentMajors": 1, "PreviousMajors": 1, "PreviousMinors": 2, "SnapshotBranches": [ "9.1", "9.0", "7.17" ] }