Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 1, 2025

These files are used for picking the starting (pre-upgrade) or ending (post-upgrade) agent versions in upgrade integration tests.

The content is based on responses from https://www.elastic.co/api/product_versions and https://snapshots.elastic.co

The current update is generated based on the following requirements:

Package version: 9.2.0

{
  "UpgradeToVersion": "9.2.0",
  "CurrentMajors": 1,
  "PreviousMajors": 1,
  "PreviousMinors": 2,
  "SnapshotBranches": [
    "9.1",
    "9.0",
    "7.17"
  ]
}

These files are used for picking the starting (pre-upgrade) or ending (post-upgrade) agent versions in upgrade integration tests.

The content is based on responses from https://www.elastic.co/api/product_versions and https://snapshots.elastic.co

The current update is generated based on the following requirements:

Package version: 9.2.0

```json
{
  "UpgradeToVersion": "9.2.0",
  "CurrentMajors": 1,
  "PreviousMajors": 1,
  "PreviousMinors": 2,
  "SnapshotBranches": [
    "9.1",
    "9.0",
    "7.17"
  ]
}
```
@github-actions github-actions bot requested a review from a team as a code owner July 1, 2025 06:20
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

1 similar comment
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

testVersions:
- 9.0.3
- 9.0.3-SNAPSHOT
- 8.19.0-SNAPSHOT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok everything is correct here except this one 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I just realised that this is correct indeed, according to the code this is what we are after

elastic-agent/magefile.go

Lines 2422 to 2435 in 0340e6b

maxSnapshots := 3
branches, err := git.GetReleaseBranches(ctx)
if err != nil {
return fmt.Errorf("failed to list release branches: %w", err)
}
// -1 because we manually add 7.17 below
if len(branches) > maxSnapshots-1 {
branches = branches[:maxSnapshots-1]
}
// it's not a part of this repository, cannot be retrieved with `GetReleaseBranches`
branches = append(branches, "7.17")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to do an exception for 8.19 in the same way we are doing for 7.17 as it will last for a long time.
WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay that makes sense, let's keep this PR at bay then, and I am gonna open a PR with the 8.19 expection just for the 9.x branches 🙂

@pkoutsovasilis
Copy link
Contributor

@ycombinator also in this PR TestUpgradeIntegrationsServer runs nothing 🙁

@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update/main-update-agent-versions-15991470246 upstream/update/main-update-agent-versions-15991470246
git merge upstream/main
git push upstream update/main-update-agent-versions-15991470246

@pkoutsovasilis
Copy link
Contributor

closing as this one #8761 got merged in main

@v1v v1v deleted the update/main-update-agent-versions-15991470246 branch July 24, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants