Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the filebeat spec file picking up packetbeat inputs #700

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -191,3 +191,4 @@
- Add `@metadata.input_id` and `@metadata.stream_id` when applying the inject stream processor {pull}527[527]
- Add liveness endpoint, allow fleet-gateway component to report degraded state, add update time and messages to status output. {issue}390[390] {pull}569[569]
- Redact sensitive information on diagnostics collect command. {issue}[241] {pull}[566]
- Fix incorrectly creating a filebeat redis input when a policy contains a packetbeat redis input. {issue}[427] {pull}[700]
2 changes: 1 addition & 1 deletion internal/pkg/agent/program/supported.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ inputs:
data_stream:
dataset: packet.icmp
type: logs
- id: packet-network_traffic.redis-387bdc6a-0acb-4ef2-9552-c21e524a2d21
type: redis
data_stream:
dataset: network_traffic.redis
type: logs
ports:
- 6379
output:
elasticsearch:
hosts:
Expand Down
7 changes: 7 additions & 0 deletions internal/pkg/agent/program/testdata/single_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,13 @@ inputs:
data_stream:
dataset: packet.icmp
type: logs
- id: packet-network_traffic.redis-387bdc6a-0acb-4ef2-9552-c21e524a2d21
type: redis
data_stream:
dataset: network_traffic.redis
type: logs
ports:
- 6379
- id: endpoint-id
type: endpoint
name: endpoint-1
Expand Down
66 changes: 38 additions & 28 deletions internal/spec/filebeat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,44 @@ rules:
on_conflict: insert_after
type: logs

# Input filtering needs to happen before any other input transformations.
# See https://github.com/elastic/elastic-agent/issues/427.
- filter_values:
selector: inputs
key: type
values:
- aws-cloudwatch
- aws-s3
- azure-eventhub
- cloudfoundry
- container
- docker
- event/file
- event/stdin
- event/tcp
- event/udp
- filestream
- gcp-pubsub
- http_endpoint
- httpjson
- journald
- kafka
- log
- log/docker
- log/redis_slowlog
- log/syslog
- logfile
- mqtt
- netflow
- o365audit
- redis
- stdin
- syslog
- tcp
- udp
- unix
- winlog

- map:
path: inputs
rules:
Expand Down Expand Up @@ -63,34 +101,6 @@ rules:
- remove_key:
key: data_stream.dataset

- filter_values:
selector: inputs
key: type
values:
- aws-cloudwatch
- aws-s3
- azure-eventhub
- cloudfoundry
- container
- docker
- gcp-pubsub
- http_endpoint
- httpjson
- journald
- kafka
- log
- mqtt
- netflow
- o365audit
- redis
- stdin
- syslog
- tcp
- udp
- unix
- winlog
- filestream

- filter_values:
selector: inputs
key: enabled
Expand Down