-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(6023): replace list with items #6437
base: main
Are you sure you want to change the base?
fix(6023): replace list with items #6437
Conversation
This pull request does not have a backport label. Could you fix it @kaanyalti? 🙏
|
|
…omes from The integration test added in this pull request needs to be removed once the list component is removed from the kibana api
40d8fbc
to
3d55a2b
Compare
Items []testKibanaApiKey `json:"items"` | ||
} | ||
|
||
// TODO: Remove test after list deprecation is complete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to add an issue link to remove the link from the kibana api, if anyone knows of such an issue please comment here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's crete an issue in our repo. this change is breaking and will be removed in 9.0
we can create a PR targeting main with skip backport right away after this one is merge, removing this test
Quality Gate failedFailed conditions |
What does this PR do?
Replaces
list
withitems
from fromkibanaFetchToken
as thelist
is deprecated in the api response and will be removed.Why is it important?
The
list
in the api response is going to be removed in favor ofitem
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works./changelog/fragments
using the changelog toolDisruptive User Impact
There shouldn't be any user impact
How to test this PR locally
Related issues
list
property when retrieving enrollment api keys #6023