-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] [Don't merge yet] Integration tests regrouping #6349
base: main
Are you sure you want to change the base?
Conversation
if os.Getenv("BUILDKITE_PULL_REQUEST") != "" { | ||
return 50 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deserves a comment in my opinion.
@@ -40,8 +40,11 @@ steps: | |||
matrix: | |||
- default | |||
- fleet | |||
- fleet-endpoint-security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ordering in these matrix lists looks arbitrary. Is there a reason for the ordering, or should we have them sorted alphabetically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, there are no ordering rules. Just placed fleet groups together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you going to sort them? If the order doesn't matter, I think it'd be a better user experience when engineers are scrolling through the results of a BK job to have them alphabetical. Plus it would make these lists more easily maintainable (until we figure out making the groups/matrix dynamic).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the 2 open comments are addressed, LGTM
Quality Gate passedIssues Measures |
I think this PR is now blocked until the issue listed here is understood? https://github.com/elastic/ingest-dev/issues/4216#issuecomment-2554151178 |
Blocked by this issue: https://github.com/elastic/ingest-dev/issues/4610 |
What does this PR do?
Extracts 3 new test groups that are executed separately:
Now the longest running group is
fleet-endpoint-security
(42 minutes)The
TestRepeatedInstallUninstall
on PRs will have 50 iterations instead of 100. For the main and release branches the iterations number will stay 100.Why is it important?
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself