[8.17](backport #5773) Exclude the coverage files from the annotate step #6331
+1
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Exclude the coverage files from the annotate step Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> (cherry picked from commit 8ebaa7d)
mergify
bot
requested review from
michalpristas and
swiatekm
and removed request for
a team
|
This pull request has not been merged yet. Could you please review and merge it @alexsapran? 🙏 |
2 similar comments
|
This pull request has not been merged yet. Could you please review and merge it @alexsapran? 🙏 |
|
This pull request has not been merged yet. Could you please review and merge it @alexsapran? 🙏 |
jlind23
approved these changes
Dec 30, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We noticed that the JUnit annotate step needed to take more time. This PR addresses that issue by not requiring it to parse the coverage files.
The generated coverage XML file was meant to be used in Jenkins to show the coverage report stats. The generated XML files were large, resulting in a problem with BK's JUnit annotate plugin.
Given that we don't operate any Jenkins instance, this PR removes the code that generated the XML coverage reports.
Now, coverage is reported only to Sonar.
Why is it important?
Reduce the time of CI step
This is an automatic backport of pull request #5773 done by [Mergify](https://mergify.com).