Remove endpoint security from linux containers #6016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @kaanyalti? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
kaanyalti
force-pushed
the
enhancement/5495_remove_endpoint_security_from_linux_containers
branch
from
fba6917 to
2f11581
Compare
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
pierrehilbert
requested review from
blakerouse
and removed request for
andrzej-stencel
kaanyalti
force-pushed
the
enhancement/5495_remove_endpoint_security_from_linux_containers
branch
from
8746aa2 to
37350ff
Compare
blakerouse
approved these changes
Nov 13, 2024
ycombinator
reviewed
Nov 13, 2024
changelog/fragments/1731517501-removed-endpoint-security-from-linux-containers.yaml
Outdated
Show resolved
Hide resolved
kaanyalti
force-pushed
the
enhancement/5495_remove_endpoint_security_from_linux_containers
branch
from
2ea013e to
e875ad3
Compare
michalpristas
approved these changes
Nov 14, 2024
kaanyalti
force-pushed
the
enhancement/5495_remove_endpoint_security_from_linux_containers
branch
from
04463d7 to
85389d5
Compare
…packaging function
…linux-containers.yaml Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
kaanyalti
force-pushed
the
enhancement/5495_remove_endpoint_security_from_linux_containers
branch
from
85389d5 to
a09ce0f
Compare
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
* enhancement(5495): added package types to expected binaries, updated packaging function * enhancement(5495): ran mage addLicenseHeader * enhancement(5495): added changelog fragment * Update changelog/fragments/1731517501-removed-endpoint-security-from-linux-containers.yaml Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * enhancement(5495): ran mage clean --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit 9c7552f) # Conflicts: # dev-tools/mage/manifest/manifest.go # magefile.go
2 tasks
blakerouse
pushed a commit
to blakerouse/elastic-agent
that referenced
this pull request
Nov 18, 2024
* enhancement(5495): added package types to expected binaries, updated packaging function * enhancement(5495): ran mage addLicenseHeader * enhancement(5495): added changelog fragment * Update changelog/fragments/1731517501-removed-endpoint-security-from-linux-containers.yaml Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * enhancement(5495): ran mage clean --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
kaanyalti
added a commit
that referenced
this pull request
Nov 18, 2024
…6042) * Remove endpoint security from linux containers (#6016) * enhancement(5495): added package types to expected binaries, updated packaging function * enhancement(5495): ran mage addLicenseHeader * enhancement(5495): added changelog fragment * Update changelog/fragments/1731517501-removed-endpoint-security-from-linux-containers.yaml Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> * enhancement(5495): ran mage clean --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit 9c7552f) # Conflicts: # dev-tools/mage/manifest/manifest.go # magefile.go * resolved conflicts --------- Co-authored-by: Kaan Yalti <kaan.yalti@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The goal of this implementation is to remove endpoint security from linux containers. Since we currently do not distribute any container other than linux containers (source), this PR does not consider selected platforms when excluding the endpoint security from container images.
Why is it important?
Endpoint security cannot run in containers since it has a systemd dependency.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testHow to test this PR locally
Package elastic-agent for a non-docker platform and validate endpoint security is installed
SNAPSHOT=true PLATFORMS=linux/arm64 PACKAGES=tar.gz EXTERNAL=true mage packagetar xzvf elastic-agent-9.0.0-SNAPSHOT-linux-arm64.tar.gzdata/elastic-agent-<commit>/componentsPackage elastic-agent for docker with linux and validate that endpoint security is not installed
SNAPSHOT=true PLATFORMS=linux/arm64 PACKAGES=docker EXTERNAL=true mage packagedocker run --entrypoint /bin/bash -it e75d83ff01b5data/elastic-agent-<commit>/componentsRelated issues