Stop elastic-agent inspect from printing output twice #5692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-laterman
added
bug
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
michel-laterman
force-pushed
the
fix-inspect
branch
from
299dea4 to
5617462
Compare
|
Thanks for fixing this @michel-laterman! I believe it closes #4471. |
ycombinator
reviewed
Oct 3, 2024
changelog/fragments/1727994385-Stop-elastic-agent-inspect-from-printing-output-twice.yaml
Outdated
Show resolved
Hide resolved
ycombinator
reviewed
Oct 3, 2024
changelog/fragments/1727994385-Stop-elastic-agent-inspect-from-printing-output-twice.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
ycombinator
approved these changes
Oct 3, 2024
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
* Stop elastic-agent inspect from printing output twice Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit c6ba6b2)
2 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
* Stop elastic-agent inspect from printing output twice Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit c6ba6b2)
2 tasks
pierrehilbert
pushed a commit
that referenced
this pull request
Oct 4, 2024
* Stop elastic-agent inspect from printing output twice Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit c6ba6b2) Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
pierrehilbert
pushed a commit
that referenced
this pull request
Oct 4, 2024
* Stop elastic-agent inspect from printing output twice Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit c6ba6b2) Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stop the
elastic-agent inspectcommand from printing the output config twice.Looks like this was introduced in #4074 when wrapping the returned error.
Why is it important?
output cannot be parsed into a generic yaml struct due to key collisions.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works./changelog/fragmentsusing the changelog toolI have added an integration test or an E2E testDisruptive User Impact
N/A
How to test this PR locally
Run
elastic-agent inspectoutput will only appear once.Related issues
Closes #4471