Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Makefile to remove reviewers #5663

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Update Makefile to remove reviewers #5663

merged 7 commits into from
Oct 2, 2024

Conversation

jlind23
Copy link
Contributor

@jlind23 jlind23 commented Oct 2, 2024 •
edited
Loading

This team is not required as a reviewer anymore as it is already part of Kibana codeowners.

This was causing the synck8s step to fail on main.

@jlind23 jlind23 requested a review from a team as a code owner October 2, 2024 10:28
@mergify mergify bot assigned jlind23 Oct 2, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 2, 2024

This pull request does not have a backport label. Could you fix it @jlind23? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 2, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 2, 2024
@gizas
Copy link
Contributor

gizas commented Oct 2, 2024

@jlind23 we use the deploy/kubernetes/makefile to update our manifests.
Are you sure that we are going to be notified when it is changed?

@jlind23 jlind23 requested a review from a team as a code owner October 2, 2024 10:59
@jlind23 jlind23 enabled auto-merge (squash) October 2, 2024 11:24
@jlind23 jlind23 merged commit 483bc67 into main Oct 2, 2024
9 of 10 checks passed
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jlind23 jlind23 deleted the jlind23-patch-3 branch October 2, 2024 11:54
mergify bot pushed a commit that referenced this pull request Oct 2, 2024
@jlind23 @mergify
Update Makefile to remove reviewers (#5663)
b6de26d 
* Update Makefile to remove reviewers

(cherry picked from commit 483bc67)
@mergify mergify bot mentioned this pull request Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pazone pazone pazone approved these changes

@gizas gizas gizas approved these changes

@tetianakravchenko tetianakravchenko Awaiting requested review from tetianakravchenko tetianakravchenko was automatically assigned from elastic/obs-cloudnative-monitoring

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@jlind23 jlind23

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-skip skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlind23 @gizas @pazone