Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add daily cron for elastic-agent #5599

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Add daily cron for elastic-agent #5599

merged 3 commits into from
Oct 2, 2024
+5 −1

Conversation

rowlandgeoff
Copy link
Contributor

Adds the daily cron that was manually configured to the yml config.

@rowlandgeoff rowlandgeoff requested a review from a team as a code owner September 23, 2024 17:48
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 23, 2024

This pull request does not have a backport label. Could you fix it @rowlandgeoff? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 23, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 23, 2024
pazone
pazone reviewed Sep 23, 2024
View reviewed changes
.buildkite/integration.pipeline.yml
@@ -95,7 +95,6 @@ steps:
command: |
buildkite-agent artifact download build/distributions/** . --step 'package-it'
.buildkite/scripts/steps/beats_tests.sh
# if: "build.env('CRON') == 'yes'"
Copy link
Contributor

@pazone pazone Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's uncomment this line. We have to run these tests only for the daily build

Copy link
Contributor Author

@rowlandgeoff rowlandgeoff Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agent team, can you confirm the behavior you want? Currently the serverless beats tests are running with every single build, and it's been like that for at least 4 months (still digging through history). Do you only want the serverless beats tests running once per day?

Copy link
Contributor Author

@rowlandgeoff rowlandgeoff Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the history. It looks like @pchila intentionally enabled them to run with every build 6 months ago - #4501

Copy link
Member

@pchila pchila Oct 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just found this PR via its backport but I can still add a bit of context:

This was supposed to be temporary to make sure that agent/beats changes on PRs would not break serverless beats tests.

The whole step was supposed to be moved to the beats CI pipeline at some point but here it still is 6 months after the fact.

@pierrehilbert @jlind23 do we have an idea when these tests can be moved off the agent pipeline and into beats CI?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were "only" waiting for buildkite to be available in the beats repository so I think we should be able to do it by now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. We'll get this on the roadmap to do soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking with https://github.com/elastic/ingest-dev/issues/4128, currently set for sprint 37

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@ycombinator ycombinator removed the request for review from pkoutsovasilis October 1, 2024 23:58
@rowlandgeoff rowlandgeoff merged commit 6183312 into main Oct 2, 2024
14 checks passed
@rowlandgeoff rowlandgeoff deleted the dailyCron branch October 2, 2024 15:42
@rowlandgeoff
Copy link
Contributor Author

I have removed the manually configured cron at https://buildkite.com/elastic/elastic-agent/settings/schedules

mergify bot pushed a commit that referenced this pull request Oct 2, 2024
@rowlandgeoff @mergify
Add daily cron for elastic-agent (#5599)
a64ab6d 
* Add daily cron

* Update integration.pipeline.yml

(cherry picked from commit 6183312)
@mergify mergify bot mentioned this pull request Oct 2, 2024
Merged
rowlandgeoff added a commit that referenced this pull request Oct 2, 2024
@mergify @rowlandgeoff
Add daily cron for elastic-agent (#5599) (#5668)
0aefb9e 
* Add daily cron

* Update integration.pipeline.yml

(cherry picked from commit 6183312)

Co-authored-by: Geoff Rowland <70981735+rowlandgeoff@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 left review comments

@pazone pazone pazone left review comments

@blakerouse blakerouse blakerouse approved these changes

@pchila pchila Awaiting requested review from pchila pchila was automatically assigned from elastic/elastic-agent-control-plane

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry

Assignees

@rowlandgeoff rowlandgeoff

Labels
backport-8.x Automated backport to the 8.x branch with mergify skip-changelog Team:Ingest-EngProd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rowlandgeoff @pazone @blakerouse @jlind23 @pchila