Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log some useful details during startup #3781

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

faec
Copy link
Contributor

@faec faec commented Nov 16, 2023

Adding some log messages I wish had been present while troubleshooting my most recent support case.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

@faec faec added Team:Elastic-Agent Label for the Agent team Cleanup skip-changelog backport-v8.11.0 Automated backport with mergify labels Nov 16, 2023
@faec faec self-assigned this Nov 16, 2023
@faec faec marked this pull request as ready for review November 16, 2023 18:07
@faec faec requested a review from a team as a code owner November 16, 2023 18:07
@faec faec requested review from AndersonQ and blakerouse November 16, 2023 18:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-16T18:07:22.751+0000

  • Duration: 16 min 9 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link

Copy link
Member

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cmacknz cmacknz merged commit 37f01b2 into elastic:main Nov 23, 2023
11 checks passed
mergify bot pushed a commit that referenced this pull request Nov 23, 2023
* add some helpful log messages

* Infof not Info

(cherry picked from commit 37f01b2)
belimawr pushed a commit to belimawr/elastic-agent that referenced this pull request Nov 28, 2023
* add some helpful log messages

* Infof not Info

(cherry picked from commit 37f01b2)

Co-authored-by: Fae Charlton <fae.charlton@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.11.0 Automated backport with mergify Cleanup skip-changelog Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants