Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync k8s migtraion to buildkite #3762

Merged
merged 20 commits into from
Nov 20, 2023
Merged

Sync k8s migtraion to buildkite #3762

merged 20 commits into from
Nov 20, 2023

Conversation

pazone
Copy link
Contributor

@pazone pazone commented Nov 13, 2023

What does this PR do?

MIgrates Sync k8s step to buildkite

@pazone pazone added enhancement New feature or request skip-changelog backport-v8.10.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify labels Nov 13, 2023
@mergify mergify bot assigned pazone Nov 13, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 13, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-15T01:23:45.005+0000

  • Duration: 15 min 49 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b buildkite_sync_k8s_migration upstream/buildkite_sync_k8s_migration
git merge upstream/main
git push upstream buildkite_sync_k8s_migration

@pazone pazone added Team:Elastic-Agent Label for the Agent team and removed backport-v8.10.0 Automated backport with mergify labels Nov 15, 2023
@pazone pazone marked this pull request as ready for review November 15, 2023 01:02
@pazone pazone requested review from a team as code owners November 15, 2023 01:02
@pazone pazone requested review from leehinman and pchila November 15, 2023 01:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@pazone pazone requested review from dliappis and mrodm and removed request for ChrsMark, tetianakravchenko, leehinman and pchila November 15, 2023 01:02
dliappis
dliappis reviewed Nov 15, 2023
View reviewed changes
Copy link

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few small comments and a potential bug, otherwise this is good.

.buildkite/scripts/install-gh.sh Outdated Show resolved Hide resolved
.buildkite/scripts/install-gh.sh Outdated Show resolved Hide resolved
.buildkite/scripts/install-gh.sh Outdated Show resolved Hide resolved
@dliappis dliappis self-requested a review November 16, 2023 14:01
dliappis
dliappis approved these changes Nov 16, 2023
View reviewed changes
Copy link

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pazone pazone requested a review from pchila November 16, 2023 15:26
@pazone
Copy link
Contributor Author

pazone commented Nov 16, 2023

The PR build is affected by #3779

@pazone pazone mentioned this pull request Nov 16, 2023
Merged
pchila
pchila approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small typo in a log, looks good otherwise

.buildkite/scripts/install-gh.sh Outdated Show resolved Hide resolved
@pchila
Copy link
Member

pchila commented Nov 20, 2023

buildkite test this

@pazone @pchila
Update .buildkite/scripts/install-gh.sh
e0605aa 
Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
@pazone pazone merged commit adf19db into main Nov 20, 2023
5 checks passed
@pazone pazone deleted the buildkite_sync_k8s_migration branch November 20, 2023 14:21
mergify bot pushed a commit that referenced this pull request Nov 20, 2023
@pazone @mergify
Sync k8s migtraion to buildkite (#3762)
3251b54 
* Sync k8s migtraion to buildkite

* Sync k8s migtraion to buildkite

* Sync k8s migtraion to buildkite

* Sync k8s migtraion to buildkite

* Sync k8s migtraion to buildkite

* Sync k8s migtraion to buildkite

* Sync k8s migtraion to buildkite

* Fix sync-k8s.sh

* try monorepo-diff step

* try monorepo-diff step

* try monorepo-diff step

* try monorepo-diff step

* try monorepo-diff step

* Cleanup

* Cleanup

* Cleanup

* Added retry fro install-gh.sh. Cleanup

* Update .buildkite/scripts/install-gh.sh

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

---------

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
(cherry picked from commit adf19db)

# Conflicts:
#	.buildkite/scripts/install-kind.sh
@mergify mergify bot mentioned this pull request Nov 20, 2023
Merged
v1v added a commit to v1v/elastic-agent that referenced this pull request Nov 20, 2023
@v1v
Merge remote-tracking branch 'upstream/main' into feature/use-ubi-9.3
eea5b03 
* upstream/main:
  Jenkins decommission (elastic#3771)
  Sync k8s migtraion to buildkite (elastic#3762)
@elastic-sonarqube Elastic SonarQube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

belimawr pushed a commit to belimawr/elastic-agent that referenced this pull request Nov 28, 2023
@mergify @pazone
Sync k8s migtraion to buildkite (elastic#3762) (elastic#3788)
87ac8c5 
* Sync k8s migtraion to buildkite

* Sync k8s migtraion to buildkite

* Sync k8s migtraion to buildkite

* Sync k8s migtraion to buildkite

* Sync k8s migtraion to buildkite

* Sync k8s migtraion to buildkite

* Sync k8s migtraion to buildkite

* Fix sync-k8s.sh

* try monorepo-diff step

* try monorepo-diff step

* try monorepo-diff step

* try monorepo-diff step

* try monorepo-diff step

* Cleanup

* Cleanup

* Cleanup

* Added retry fro install-gh.sh. Cleanup

* Update .buildkite/scripts/install-gh.sh

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>

---------

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
(cherry picked from commit adf19db)

# Conflicts:
#	.buildkite/scripts/install-kind.sh

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchila pchila pchila approved these changes

@dliappis dliappis dliappis approved these changes

@mrodm mrodm Awaiting requested review from mrodm

@tetianakravchenko tetianakravchenko Awaiting requested review from tetianakravchenko

@leehinman leehinman Awaiting requested review from leehinman

Assignees

@pazone pazone

Labels
backport-v8.11.0 Automated backport with mergify enhancement New feature or request skip-changelog Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pazone @elasticmachine @pchila @dliappis