Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong logging for wrong fleet api version response #3673

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

pchila
Copy link
Member

@pchila pchila commented Oct 30, 2023

What does this PR do?

Fix a log message when fleet returns an error due to a wrong api version

Why is it important?

This avoids a noisy formatting error in logs

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pchila pchila added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Cleanup backport-v8.11.0 Automated backport with mergify labels Oct 30, 2023
@pchila pchila self-assigned this Oct 30, 2023
@pchila pchila requested a review from a team as a code owner October 30, 2023 15:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-03T13:58:30.228+0000

  • Duration: 19 min 12 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pchila
Copy link
Member Author

pchila commented Nov 2, 2023

buildkite test this

@pchila pchila force-pushed the fix_logging_fleet_api_version branch from ed3b854 to 4b6850c Compare November 2, 2023 16:08
@pchila pchila force-pushed the fix_logging_fleet_api_version branch from 4b6850c to 55c4e26 Compare November 3, 2023 13:58
Copy link

@pchila pchila merged commit 5f891b0 into elastic:main Nov 3, 2023
7 checks passed
mergify bot pushed a commit that referenced this pull request Nov 3, 2023
pchila added a commit that referenced this pull request Nov 6, 2023
pchila added a commit that referenced this pull request Nov 6, 2023
(cherry picked from commit 5f891b0)

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.11.0 Automated backport with mergify Cleanup skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants