-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong logging for wrong fleet api version response #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchila
added
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Cleanup
backport-v8.11.0
Automated backport with mergify
labels
Oct 30, 2023
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
cmacknz
approved these changes
Oct 30, 2023
intxgo
approved these changes
Oct 30, 2023
michalpristas
approved these changes
Oct 31, 2023
blakerouse
approved these changes
Nov 1, 2023
buildkite test this |
pchila
force-pushed
the
fix_logging_fleet_api_version
branch
from
November 2, 2023 16:08
ed3b854
to
4b6850c
Compare
pchila
force-pushed
the
fix_logging_fleet_api_version
branch
from
November 3, 2023 13:58
4b6850c
to
55c4e26
Compare
SonarQube Quality Gate |
mergify bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
(cherry picked from commit 5f891b0)
pchila
added a commit
that referenced
this pull request
Nov 6, 2023
(cherry picked from commit 5f891b0)
pchila
added a commit
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v8.11.0
Automated backport with mergify
Cleanup
skip-changelog
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a log message when fleet returns an error due to a wrong api version
Why is it important?
This avoids a noisy formatting error in logs
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragments
using the changelog tool[ ] I have added an integration test or an E2E testAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
Questions to ask yourself