Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude fake components from sonar analysis #3360

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

pchila
Copy link
Member

@pchila pchila commented Sep 6, 2023

What does this PR do?

Exclude fake components used in elastic-agent tests from sonarqube analysis

Why is it important?

To avoid false positives in sonarqube quality gate results

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pchila pchila added Team:Elastic-Agent Label for the Agent team Testing labels Sep 6, 2023
@pchila pchila requested a review from a team as a code owner September 6, 2023 14:20
@pchila pchila self-assigned this Sep 6, 2023
@pchila pchila requested a review from blakerouse September 6, 2023 14:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2023

This pull request does not have a backport label. Could you fix it @pchila? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Sep 6, 2023
@pchila pchila enabled auto-merge (squash) September 6, 2023 14:25
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we don't need to write tests for code that is used for unit tests ;-)

@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-06T14:20:25.834+0000

  • Duration: 28 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 6253
Skipped 55
Total 6308

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.765% (80/81) 👍
Files 67.719% (193/285) 👍
Classes 66.292% (354/534) 👍
Methods 53.037% (1109/2091) 👍
Lines 38.609% (12654/32775) 👍 0.006
Conditionals 100.0% (0/0) 💚

@cmacknz cmacknz disabled auto-merge September 6, 2023 17:00
@cmacknz
Copy link
Member

cmacknz commented Sep 6, 2023

Test failures unrelated, merging.

@cmacknz cmacknz merged commit 243c76b into elastic:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants