-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.10](backport #3249) Add ticker to uninstall RemovePath and the error explain what was attempted #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
@Mergifyio update |
✅ Branch has been successfully updated |
🌐 Coverage report
|
b955d48
to
1dc54ea
Compare
This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏 |
AndersonQ
approved these changes
Aug 28, 2023
@pierrehilbert @cmacknz could we get this merged as the tests failing are the flaky integration tests and this PR fixes other flaky test? |
AndersonQ
added a commit
to AndersonQ/elastic-agent
that referenced
this pull request
Sep 5, 2023
Revert "correctly identify retryable errors when uninstalling on Windows (elastic#3317) (elastic#3324)" - commit 49e6cb9. Revert "add ticker to uninstall RemovePath and error explain what was attempted (elastic#3249) (elastic#3270)" - commit 347ea8b.
cmacknz
pushed a commit
that referenced
this pull request
Sep 5, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
Revert "correctly identify retryable errors when uninstalling on Windows (#3317) (#3324)" - commit 49e6cb9. Revert "add ticker to uninstall RemovePath and error explain what was attempted (#3249) (#3270)" - commit 347ea8b. (cherry picked from commit 9e656b7) # Conflicts: # changelog/fragments/1691060806-Processor-support-for-hints-autodiscover.yaml
cmacknz
pushed a commit
that referenced
this pull request
Sep 7, 2023
Revert "correctly identify retryable errors when uninstalling on Windows (#3317) (#3324)" - commit 49e6cb9. Revert "add ticker to uninstall RemovePath and error explain what was attempted (#3249) (#3270)" - commit 347ea8b. (cherry picked from commit 9e656b7) # Conflicts: # changelog/fragments/1691060806-Processor-support-for-hints-autodiscover.yaml Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3249 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com