Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.10](backport #3249) Add ticker to uninstall RemovePath and the error explain what was attempted #3270

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 21, 2023

This is an automatic backport of pull request #3249 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested a review from a team as a code owner August 21, 2023 15:09
@mergify mergify bot requested review from AndersonQ and michalpristas and removed request for a team August 21, 2023 15:09
@mergify mergify bot added the backport label Aug 21, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 21, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-24T17:03:59.967+0000

  • Duration: 29 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 6217
Skipped 47
Total 6264

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Aug 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@AndersonQ
Copy link
Member

@Mergifyio update

@mergify
Copy link
Contributor Author

mergify bot commented Aug 23, 2023

update

✅ Branch has been successfully updated

@AndersonQ AndersonQ removed the request for review from michalpristas August 23, 2023 15:37
@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 23, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.765% (80/81) 👍 0.015
Files 67.368% (192/285) 👎 -0.464
Classes 66.105% (353/534) 👎 -0.187
Methods 52.874% (1104/2088) 👍
Lines 38.535% (12584/32656) 👎 -0.177
Conditionals 100.0% (0/0) 💚

@AndersonQ AndersonQ force-pushed the mergify/bp/8.10/pr-3249 branch from b955d48 to 1dc54ea Compare August 24, 2023 17:03
@mergify
Copy link
Contributor Author

mergify bot commented Aug 28, 2023

This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏

@AndersonQ AndersonQ enabled auto-merge (squash) August 28, 2023 15:42
@AndersonQ
Copy link
Member

@pierrehilbert @cmacknz could we get this merged as the tests failing are the flaky integration tests and this PR fixes other flaky test?

@pierrehilbert pierrehilbert disabled auto-merge August 28, 2023 17:32
@pierrehilbert pierrehilbert merged commit 347ea8b into 8.10 Aug 28, 2023
@pierrehilbert pierrehilbert deleted the mergify/bp/8.10/pr-3249 branch August 28, 2023 17:33
AndersonQ added a commit to AndersonQ/elastic-agent that referenced this pull request Sep 5, 2023
Revert "correctly identify retryable errors when uninstalling on Windows (elastic#3317) (elastic#3324)"
  -  commit 49e6cb9.

Revert "add ticker to uninstall RemovePath and error explain what was attempted (elastic#3249) (elastic#3270)"
  - commit 347ea8b.
@AndersonQ AndersonQ mentioned this pull request Sep 5, 2023
1 task
cmacknz pushed a commit that referenced this pull request Sep 5, 2023
Revert "correctly identify retryable errors when uninstalling on Windows (#3317) (#3324)"
  -  commit 49e6cb9.

Revert "add ticker to uninstall RemovePath and error explain what was attempted (#3249) (#3270)"
  - commit 347ea8b.
mergify bot pushed a commit that referenced this pull request Sep 5, 2023
Revert "correctly identify retryable errors when uninstalling on Windows (#3317) (#3324)"
  -  commit 49e6cb9.

Revert "add ticker to uninstall RemovePath and error explain what was attempted (#3249) (#3270)"
  - commit 347ea8b.

(cherry picked from commit 9e656b7)

# Conflicts:
#	changelog/fragments/1691060806-Processor-support-for-hints-autodiscover.yaml
cmacknz pushed a commit that referenced this pull request Sep 7, 2023
Revert "correctly identify retryable errors when uninstalling on Windows (#3317) (#3324)"
  -  commit 49e6cb9.

Revert "add ticker to uninstall RemovePath and error explain what was attempted (#3249) (#3270)"
  - commit 347ea8b.

(cherry picked from commit 9e656b7)

# Conflicts:
#	changelog/fragments/1691060806-Processor-support-for-hints-autodiscover.yaml

Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants