Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optional strict checking of variable names in EQL expressions #2678

Merged
merged 15 commits into from
May 15, 2023
Merged

Allow optional strict checking of variable names in EQL expressions #2678

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8d52f97
Remove some unused AST helpers
faec May 10, 2023
fcaf2c8
Let EQL evaluation optionally require strict variable checking
faec May 11, 2023
bc3d30c
Merge branch 'main' of github.com:elastic/elastic-agent into eql-stri…
faec May 11, 2023
311d97a
clarify comment
faec May 11, 2023
7fbbb0c
add clarifying comment
faec May 11, 2023
a8334aa
reorder spec file conditions
faec May 12, 2023
39f4195
document variables usable by spec files, clean up variable creation
faec May 12, 2023
b95ccf9
clarify logical short-circuit behavior, add tests to confirm
faec May 12, 2023
f663bd0
relocate docs to directory suggested by blake
faec May 12, 2023
c86eb52
finish spec file unit tests
faec May 12, 2023
9e60d47
fix invalid variable in spec files
faec May 12, 2023
34fe62f
lint
faec May 12, 2023
2a2c0eb
clarify input vs component language
faec May 15, 2023
d6eb663
add more tests
faec May 15, 2023
7baf185
adjust string formatting
faec May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix invalid variable in spec files
  • Loading branch information
@faec
faec committed May 12, 2023
commit 9e60d47f623aef006159a40848e57d67d08f0c83
2 changes: 1 addition & 1 deletion specs/cloud-defend.spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ inputs:
- elasticsearch
runtime:
preventions:
- condition: ${runtime.user.root} == false
- condition: ${user.root} == false
message: "Elastic Agent must be running as root"
command: &args
args:
Expand Down
4 changes: 2 additions & 2 deletions specs/endpoint-security.spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ inputs:
preventions:
- condition: ${runtime.arch} == 'arm64' and ${runtime.family} == 'redhat' and ${runtime.major} == '7'
message: "No support for RHEL7 on arm64"
- condition: ${runtime.user.root} == false
- condition: ${user.root} == false
message: "Elastic Agent must be running as root"
service:
cport: 6788
Expand Down Expand Up @@ -64,7 +64,7 @@ inputs:
- logstash
runtime:
preventions:
- condition: ${runtime.user.root} == false
- condition: ${user.root} == false
message: "Elastic Agent must be running as Administrator or SYSTEM"
service:
cport: 6788
Expand Down
2 changes: 1 addition & 1 deletion specs/pf-host-agent.spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ inputs:
- elasticsearch
runtime:
preventions:
- condition: ${runtime.user.root} == false
- condition: ${user.root} == false
message: "Elastic Agent must be running as root"
command:
args:
Expand Down