-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable monitoring buffer for elastic-agent (#30471) #211
Conversation
* Enable monitoring buffer for elastic-agent * Add diagnostics collect support * Fix typos * Fix issues * Fix metrics collection * Add CHANGELOG * Update x-pack/elastic-agent/CHANGELOG.next.asciidoc Co-authored-by: Bryan Clement <bclement01@gmail.com> * Remove unused config * changelog order Co-authored-by: Bryan Clement <bclement01@gmail.com> (cherry picked from commit 0099f5cf517ee03c88c2c33909a178c04329840e)
This pull request does not have a backport label. Could you fix it @narph? 🙏
NOTE: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter warning are valid, we didn't have a linter on beats before that went in, sorry @narph :(
|
||
func zipMetrics(zw *zip.Writer, metrics *proto.ProcMetricsResponse) error { | ||
zf, err := zw.Create("metrics/") | ||
if err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting, I believe this is a real bug, I don't think you need to create zw.Create()
with only the metrics/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation for zip states that adding a trailing slash creates a directory: https://pkg.go.dev/archive/zip#Writer.Create
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
Backport from elastic/beats#30559
Enable monitoring buffer for elastic-agent
Add diagnostics collect support
Fix typos
Fix issues
Fix metrics collection
Add CHANGELOG
Update x-pack/elastic-agent/CHANGELOG.next.asciidoc
Co-authored-by: Bryan Clement bclement01@gmail.com
Remove unused config
changelog order
Co-authored-by: Bryan Clement bclement01@gmail.com
(cherry picked from commit 0099f5cf517ee03c88c2c33909a178c04329840e)