Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] Increase Agent logfile size #1997

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

michalpristas
Copy link
Contributor

What does this PR do?

This PR increases logfile size limit from 10MB to 20MB

Why is it important?

As log files of processes are removed and events are persisted in agent log file we need to increase agent logfile size to keep capacity of the logs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Fixes: #1992

@michalpristas michalpristas added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team skip-changelog backport-v8.6.0 Automated backport with mergify labels Dec 23, 2022
@michalpristas michalpristas requested a review from a team as a code owner December 23, 2022 09:14
@michalpristas michalpristas self-assigned this Dec 23, 2022
@michalpristas michalpristas requested review from AndersonQ and blakerouse and removed request for a team December 23, 2022 09:14
@michalpristas michalpristas changed the title Increase Agent logfile size [V2] Increase Agent logfile size Dec 23, 2022
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 23, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-23T09:34:17.133+0000

  • Duration: 16 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 4749
Skipped 13
Total 4762

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.305% (58/59) 👍
Files 69.268% (142/205) 👍
Classes 69.231% (270/390) 👍
Methods 54.128% (826/1526) 👍
Lines 39.224% (8963/22851) 👎 -0.044
Conditionals 100.0% (0/0) 💚

@michalpristas michalpristas merged commit ea96b69 into elastic:main Dec 23, 2022
mergify bot pushed a commit that referenced this pull request Dec 23, 2022
(cherry picked from commit ea96b69)
cmacknz pushed a commit that referenced this pull request Dec 23, 2022
(cherry picked from commit ea96b69)

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.6.0 Automated backport with mergify enhancement New feature or request skip-changelog Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase the default log rotation settings for the new combined agent log file
3 participants