Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mage notice in favour of make notice #1108

Merged
merged 7 commits into from
Sep 13, 2022

Commits on Sep 7, 2022

  1. fix race condition on magefile

    Fix a race condition when calling `go-licence-detector`. The original
    code waited for a goroutine to write to `go-licence-detector`'s stdin
    before starting the command, so the mage target was hanging.
    
    This commit fixes it, adds logging (when verbose set) to the command
    run as well as improves the error message.
    belimawr committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    2d3a9e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Update CHANGELOG.next.asciidoc

    Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
    belimawr and cmacknz authored Sep 8, 2022
    Configuration menu
    Copy the full SHA
    cc43dfb View commit details
    Browse the repository at this point in the history
  2. dev-tools: fix call to go-lincence-detector

    This commit fixes the call to `go-licence-detector` by removing the
    `-depsOut ""` argument.
    
    The NOTICE.txt file is also updated.
    belimawr committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    7a3c144 View commit details
    Browse the repository at this point in the history
  3. make CI happy

    belimawr committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    87a2bdc View commit details
    Browse the repository at this point in the history
  4. append notice data to NOTICE.txt

    Our `Makefile` when running the `notice` rule appends some data to
    `NOTICE.txt`, this commit makes the `notice` target on our
    `magefile.go` to behave the same way.
    belimawr committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    55f1597 View commit details
    Browse the repository at this point in the history
  5. wip

    belimawr committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    54d7aad View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Remove mage notice in favour of make notice

    The current implementation of mage notice is not working because it
    was never finalised, the fact that it and `make notice` exist only
    generates confusion.
    
    This commit removes the `mage notice` and documents that `make notice`
    should be used insted for the time being.
    
    In the long run we want to use the implementation on
    `elastic-agent-libs`, however it is not woking at the monent.
    
    Closes elastic#1107
    belimawr committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    1ff02dc View commit details
    Browse the repository at this point in the history