Skip to content

feat: deprecate observer output #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2025
Merged

feat: deprecate observer output #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abe623a
feat: deprecate observer output
kruskall Nov 4, 2025
9625cbd
Update core.go
kruskall Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions logp/core.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,8 @@ func TestingSetup(options ...Option) error {

// ObserverLogs provides the list of logs generated during the observation
// process.
//
// Deprecated: Use logptest.NewTestingLoggerWithObserver.
func ObserverLogs() *observer.ObservedLogs {
return loadLogger().observedLogs
}
Expand Down
2 changes: 2 additions & 0 deletions logp/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ func WithSelectors(selectors ...string) Option {

// ToObserverOutput specifies that the output should be collected in memory so
// that they can be read by an observer by calling ObserverLogs().
//
// Deprecated: Use logptest.NewTestingLoggerWithObserver.
func ToObserverOutput() Option {
return func(cfg *Config) {
cfg.toObserver = true
Expand Down
Loading