Fixes for Pandas 2 support #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Better solution might exist)
|
Thank you for this! Will review later this week.
It's OK to break Pandas 1.5 support in a new release if it brings Pandas 2.0 support. |
bartbroere
changed the title
|
buildkite test this please |
bartbroere
commented
Jan 28, 2025
bartbroere
commented
Jan 29, 2025
bartbroere
commented
Jan 29, 2025
|
buildkite test this please |
From pandas 2 and upwards, index is set to None by default
bartbroere
commented
Jan 30, 2025
|
@pquentin I addressed all open comments, and I think the pull request is ready for re-review. Feel free to re-open comments if something needs to be changed. |
|
buildkite test this please |
pquentin
reviewed
Feb 3, 2025
|
buildkite test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started to work on the Pandas 2 support again. Locally I'm testing with an environment that already uses Pandas 2, and these are the changes that were required to get some tests fixed.
The objective is to not break the Pandas 1.5 support, so these should be safe to merge. Where it seemed useful I added some line comments with the reasoning behind the change.
Some more PRs might follow later this week. Once all tests pass on Pandas 2, we can update the CI to include it in the test matrix.