-
Notifications
You must be signed in to change notification settings - Fork 111
Expansion support #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Expansion support #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2024
davidkyle
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces a new model type for
text_expansion
which is related to Sparse vector query .Until Elasticsearch and Eland 8.16, only ELSER model can be used for this query type, but with this PR and this, users can upload other sparse vector model from hugging face such as:
This is essentially the same PR as #706 but I fixed formatter issue.
Related:
This pull request introduces a new model type for text expansion and refines error messaging for unsupported task types. The most important changes include the addition of the
_TraceableTextExpansionModel
class and updates to the_create_traceable_model
method to handle this new model type.New Model Type for Text Expansion:
_TraceableTextExpansionModel
class with a_prepare_inputs
method to handle text expansion tasks. (eland/ml/pytorch/transformers.py
)_create_traceable_model
method to include logic for creating a_TraceableTextExpansionModel
when the task type is "text_expansion". (eland/ml/pytorch/transformers.py
)Error Messaging Improvement:
_create_traceable_model
to clarify that the task type must be one of the supported task types. (eland/ml/pytorch/transformers.py
)