-
Notifications
You must be signed in to change notification settings - Fork 438
Revises event.created and expands with event.start and event.end #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -128,6 +128,27 @@ | |
|
||
In case the two timestamps are identical, @timestamp should be used. | ||
|
||
- name: start | ||
type: date | ||
description: > | ||
event.start contains the date when the event started. | ||
|
||
This timestamp is distinct from @timestamp in that @timestamp contains | ||
the processed timestamp. For logs these two timestamps can be different | ||
as the timestamp in the log line and when the event is read for example | ||
by Filebeat are not identical. `@timestamp` must contain the timestamp | ||
extracted from the log line, event.start when the log line is read. | ||
The same could apply to package capturing where @timestamp contains the | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "package capturing" => "packet capture" (same correction on line below as well) |
||
timestamp extracted from the network package and event.created when the | ||
event was created. | ||
|
||
In case the two timestamps are identical, @timestamp should be used. | ||
|
||
- name: end | ||
type: date | ||
description: > | ||
event.end contains the date when the event ended. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You have a nice description in the PR of this with an example. Could you add this here? |
||
|
||
- name: risk_score | ||
type: float | ||
description: > | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me that is
event.created
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not explain
event.start
in terms of the phenomenon of reading log files.I think it would be more beneficial to specifically explain
start
/end
specifically in terms of the observation of long running phenomena, like flows.Some points I'd try to hit in this description and/or
end
:start
andend
usually go hand in hand. Although there may be exceptions (missing field) in the case of partial flows.start
can actually be hours before@timestamp
, if the observed phenomenon started a long time ago and was just reported.event.duration
.To @ruflin's point, having 2/3 fields out of
start
,end
andduration
is enough to derive the 3rd fields. I'd rather have 3/3, but we may (or may not) want to mention that 2/3 can be enough?