Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type in code signature #2382

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Sep 17, 2024

Change the type of code_signature.flags to keyword, which is what it should be. Also add a unit test that will verify all types are valid.

  • Have you signed the contributor license agreement?  ✅
  • Have you followed the contributor guidelines? ✅
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? n/a
  • If submitting code/script changes, have you verified all tests pass locally using make test? ✅
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? ✅
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. ✅
  • Have you added an entry to the CHANGELOG.next.md? n/a

@mjwolf mjwolf requested a review from a team as a code owner September 17, 2024 18:15
Copy link

Documentation changes preview: https://ecs_bk_2382.docs-preview.app.elstc.co/diff

@@ -130,6 +130,41 @@ def test_normalize_always_array(self):
for (field_name, field) in self.ecs_fields.items():
self.assertIsInstance(field.get('normalize'), list, field_name)

def test_valid_type(self):
valid_types = ['binary',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewkroh andrewkroh added the bug Something isn't working label Sep 23, 2024
@mjwolf mjwolf merged commit 220ecee into elastic:main Sep 23, 2024
2 of 3 checks passed
@mjwolf mjwolf deleted the fix-type-code-signature branch September 23, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants