Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune container image fields to align with Otel SemConv #2282

Closed
wants to merge 2 commits into from

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Oct 2, 2023

This PR tunes the container.image.* fields to align with Otel's SemConv.
Specifically after open-telemetry/semantic-conventions#159 have been merged, we need to adjust ECS to at least:

  1. container.image.tag -> container.image.tags
  2. container.image.hash.all -> container.image.repo_digests

For now I have added container.image.repo_digests as a new field and we can keep container.image.hash.all for backwards compatibility if we prefer.


  • Have you signed the contributor license agreement? ✅
  • Have you followed the contributor guidelines? ✅
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process?
  • If submitting code/script changes, have you verified all tests pass locally using make test?
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? ✅
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. ✅
  • Have you added an entry to the CHANGELOG.next.md? ✅

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark requested a review from a team as a code owner October 2, 2023 07:29
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Documentation changes preview: https://ecs_2282.docs-preview.app.elstc.co/diff

@ChrsMark ChrsMark changed the title Tune container image fields to allign with Otel SemConv Tune container image fields to align with Otel SemConv Oct 2, 2023
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Copy link

github-actions bot commented Dec 2, 2023

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale Stale issues and pull requests label Dec 2, 2023
@ChrsMark
Copy link
Member Author

ChrsMark commented Dec 4, 2023

cc: @elastic/ecs

@norrietaylor
Copy link
Member

cc/ @trisch-me @mjwolf

@github-actions github-actions bot removed the stale Stale issues and pull requests label Dec 5, 2023
@ChrsMark
Copy link
Member Author

ChrsMark commented Dec 8, 2023

Closing for now since the plan is not to update ECS back with changes from SemConv.

@ChrsMark ChrsMark closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants