Skip to content

Add concern about automatic inclusion of dimensions #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add concern about automatic inclusion of dimensions #2196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion rfcs/text/0039-tsdb-dimensions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,25 @@ The goal here is to research and understand the impact of these changes on users

## Concerns

No concerns are known as of now. Presence of the `dimension:true` does not impact functionality. Elastic Stack version 8.7 is essential for this.
Presence of the `dimension:true` does not impact functionality. Elastic Stack version 8.7 is essential for this.

### Automatic inclusion of ECS dimensions in index mappings

Implementations consuming dimensions defined in ECS need to take into account
that changes in the set of dimensions of a data set can produce different time
series, even for the same data. This can produce unexpected results.

Automatic inclusion of ECS dimensions should be done with care, informing
developers whenever possible of possible changes in the set of dimensions for
their data sets when they upgrade to a version of ECS including changes in
dimensions. Additionaly, opt-in/out mechanisms can be implemented to give
developers more control on what dimensions are automatically included on their
solutions.

Inclusion of new dimensions in ECS should be done with special care, to avoid
silently introducing unexpected changes on implementations that directly include
dimensions from ECS.

<!--
Stage 1: Identify potential concerns, implementation challenges, or complexity. Spend some time on this. Play devil's advocate. Try to identify the sort of non-obvious challenges that tend to surface later. The goal here is to surface risks early, allow everyone the time to work through them, and ultimately document resolution for posterity's sake.
-->
Expand Down