Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Version Type Field Migration - Stage 0 #1309

Merged
merged 6 commits into from
Apr 22, 2021

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Mar 18, 2021

Summary

Stage 0 proposal for adopting the version type for fields containing software version values.

version is specialized to support precedence rules based on Semantic Versioning.

Stage 0 (Strawperson) Criteria:

  • Discuss with domain or subject matter experts the utility of these changes
  • Discuss with ECS team whether these changes seem appropriate for ECS

Preview of markdown proposal

@ebeahan ebeahan added the RFC label Mar 18, 2021
@ebeahan ebeahan self-assigned this Mar 18, 2021
@ebeahan ebeahan changed the title [RFC] Version Type Field Migration [RFC] Version Type Field Migration - Stage 0 Mar 31, 2021
@ebeahan ebeahan requested review from djptek and kgeller April 21, 2021 20:13
@ebeahan
Copy link
Member Author

ebeahan commented Apr 21, 2021

Discussed in another channel that engaging the owners of the proposed version fields and determining which of these fields are candidates for version are good next steps. After some thought, I think it would be best to hold off on those broader, cross-team discussions until the stage 1 PR.

Stage 0 acceptance is agreement that the proposed idea has merit for consideration into ECS, so I think we focus on those criteria in this PR.

kgeller
kgeller previously approved these changes Apr 22, 2021
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I agree with your sentiment about having the broader discussion in phase 1.

@ebeahan ebeahan merged commit d9be153 into elastic:master Apr 22, 2021
@ebeahan ebeahan deleted the rfc/0000/adopt-version-field-type branch April 22, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants