Skip to content

Conversation

@rw-access
Copy link
Contributor

Related to #678

Started an RFC to model target processes as process.target.*

@ebeahan ebeahan added the RFC label Mar 4, 2021
ebeahan
ebeahan previously approved these changes Mar 4, 2021
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for stage 0.

Should we hold off merging until @andrewstucki has a chance to review?

Co-authored-by: Eric Beahan <ebeahan@gmail.com>
@ebeahan
Copy link
Member

ebeahan commented Mar 4, 2021

Also, the failed tests should now be addressed by #1283. I can rebase this branch when I set the date and RFC number at merge time.

@rw-access rw-access marked this pull request as ready for review March 8, 2021 17:01
ebeahan
ebeahan previously approved these changes Mar 8, 2021
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Will hold off merging until @andrewstucki reviews.

andrewstucki
andrewstucki previously approved these changes Mar 9, 2021
Copy link
Contributor

@andrewstucki andrewstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for putting this together @rw-access

@ebeahan ebeahan dismissed stale reviews from andrewstucki and themself via 85aae2b March 9, 2021 17:26
@ebeahan ebeahan merged commit 21f13e5 into elastic:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants