-
Notifications
You must be signed in to change notification settings - Fork 20
Ensure ecs.version is treated as a top level field #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This ensures the `ecs.version` is always written as top level field without arbitrary nesting it. This aligns the spec closer to the written documentation: https://github.com/elastic/ecs-logging/tree/main/spec#minimum-viable-product
Note (to self, I guess): I'll have to change the node.js ecs-logging libs to do this. Currently they are written log records like this:
|
Yeah, python only does this with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already using ecs.version
as a top-level field in Java.
Thanks for the reviews! Merging now. |
This ensures the
ecs.version
is always written as top level field without arbitrary nesting it.This aligns the spec closer to the written documentation:
https://github.com/elastic/ecs-logging/tree/main/spec#minimum-viable-product