Skip to content

Ensure ecs.version is treated as a top level field #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

Mpdreamz
Copy link
Member

This ensures the ecs.version is always written as top level field without arbitrary nesting it.

This aligns the spec closer to the written documentation:

https://github.com/elastic/ecs-logging/tree/main/spec#minimum-viable-product

This ensures the `ecs.version` is always written as top level field without arbitrary nesting it.

This aligns the spec closer to the written documentation:

https://github.com/elastic/ecs-logging/tree/main/spec#minimum-viable-product
@Mpdreamz Mpdreamz requested a review from felixbarny January 18, 2023 15:34
@apmmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-18T15:35:09.538+0000

  • Duration: 3 min 58 sec

@trentm
Copy link
Member

trentm commented Jan 19, 2023

Note (to self, I guess): I'll have to change the node.js ecs-logging libs to do this. Currently they are written log records like this:

{"log.level":"debug","@timestamp":"2023-01-19T17:51:47.649Z","log":{"logger":"elastic-apm-node"},"ecs":{"version":"1.6.0"},"message":"..."}

@basepi
Copy link

basepi commented Jan 19, 2023

Yeah, python only does this with log.level right now, iirc.

@apmmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-20T04:38:00.032+0000

  • Duration: 6 min 30 sec

@apmmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-23T04:38:00.031+0000

  • Duration: 7 min 33 sec

Copy link
Member

@SylvainJuge SylvainJuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already using ecs.version as a top-level field in Java.

@Mpdreamz
Copy link
Member Author

Thanks for the reviews! Merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants