feat: add morgan types to work with typescript #119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
github-actions
bot
added
agent-nodejs
❕ Build Aborted
Expand to view the summary
Build stats
Steps errors
Expand to view the steps failures
|
|
Hi @floross. Thanks very much for your PR! I'm sorry that I didn't get back to you way back when you submitted this. Are you able to sign our CLA (at https://www.elastic.co/contributor-agreement)? Then I'll be able to get this in this week. |
trentm
approved these changes
Oct 18, 2023
trentm
added a commit
that referenced
this pull request
Oct 27, 2023
This updates the three @elastic/ecs-*-format packages to support the following import styles from JS and TS code: 1. `const { ecsFormat } = require('@elastic/ecs-pino-format);` in JS and TS. The preferred import style for JS code using CommonJS. 2. `import { ecsFormat } from '@elastic/ecs-pino-format';` in JS and TS. ES module (ESM) import style. This is the preferred style for TypeScript code and for JS developers using ESM. 3. `const ecsFormat = require('@elastic/ecs-pino-format');` in JS. The old, deprecated import method. Still supported for backward compat. 4. `import ecsFormat from '@elastic/ecs-pino-format';` in JS and TS. This works, but is deprecated. Prefer #2 style. 5. `import * as EcsPinoFormat from '@elastic/ecs-pino-format';` in TS. One must then use `EcsPinoFormat.ecsFormat()`. Note that this *excludes* support for this TS-only style: `import escFormat = require('@elastic/ecs-pino-format');` This also adds types for ecs-morgan-format, based on #119 and #90. I'd had an earlier start on this in #96. Replaces: #96 Closes: #90 Closes: #119
trentm
added a commit
that referenced
this pull request
Oct 30, 2023
…#165) This updates the three @elastic/ecs-*-format packages to support the following import styles from JS and TS code: 1. `const { ecsFormat } = require('@elastic/ecs-pino-format);` in JS and TS. The preferred import style for JS code using CommonJS. 2. `import { ecsFormat } from '@elastic/ecs-pino-format';` in JS and TS. ES module (ESM) import style. This is the preferred style for TypeScript code and for JS developers using ESM. 3. `const ecsFormat = require('@elastic/ecs-pino-format');` in JS. The old, deprecated import method. Still supported for backward compat. 4. `import ecsFormat from '@elastic/ecs-pino-format';` in JS and TS. This works, but is deprecated. Prefer #2 style. 5. `import * as EcsPinoFormat from '@elastic/ecs-pino-format';` in TS. One must then use `EcsPinoFormat.ecsFormat()`. Note that this *excludes* support for this TS-only style: `import escFormat = require('@elastic/ecs-pino-format');` This also adds types for ecs-morgan-format, based on #119 and #90. I'd had an earlier start on this in #96. Replaces: #96 Closes: #90 Closes: #119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add types information to the morgan elastic package (
@elastic/ecs-morgan-format)