-
Notifications
You must be signed in to change notification settings - Fork 81
Fix to support JPMS #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix to support JPMS #334
Conversation
💚 CLA has been signed |
The process to sign the contributor agreement does not work for me https://www.elastic.co/contributor-agreement Only the progress bar runs to end, but nothing more happens. |
The commits are using |
This is needed to support JPMS, because 1.3.x is the first release including the module-info file.
|
Now the module names are named by the packages
|
Unfortunately I think the fix isn't that trivial, because we need to target java 7, which can't compile |
Thanks for your feedback. Currently the fix must be extended. The main idea I currently have is to compile the sources twice: In the first step everything is compiled with Java 9 and after that everything with Java 7 excluding module-info.java in a similar way as it is mentioned here: https://maven.apache.org/plugins/maven-compiler-plugin/examples/module-info.html |
This is a fix for #332.
This change needs to update the dependency of logback-classic from 1.2.13 to 1.3.15, because 1.3.x is the first version, which supports JPMS, i.e. it includes the needed module-info file.
Only in the main project ecs-logging-core and in logback-ecs-encoder the module-info file has been added. Also in jul-ecs-formatter and log4j-* projects a module-info file could be added in a similar way.