Skip to content

maven: upgrade target to 7 #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2023
Merged

maven: upgrade target to 7 #210

merged 3 commits into from
Feb 16, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Feb 16, 2023

Otherwise, when using JDK17, the same as the APM AGent java, it will cause an error

[INFO] -------------------------------------------------------------
--
  | [ERROR] COMPILATION ERROR :
  | [INFO] -------------------------------------------------------------
  | [ERROR] Source option 6 is no longer supported. Use 7 or later.
  | [ERROR] Target option 6 is

@v1v v1v requested review from a team February 16, 2023 13:21
@v1v v1v self-assigned this Feb 16, 2023
jackshirazi
jackshirazi approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@jackshirazi jackshirazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea why it was set to 6, we don't support pre-7. Thanks!

@v1v v1v merged commit 20a9386 into elastic:main Feb 16, 2023
@v1v v1v deleted the feature/update-source branch February 16, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackshirazi jackshirazi jackshirazi approved these changes

@reakaleek reakaleek reakaleek approved these changes

Assignees

@v1v v1v

Labels
agent-java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1v @jackshirazi @reakaleek