-
Notifications
You must be signed in to change notification settings - Fork 81
Convert docs to asciidoc #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @bmorelli25 could you help with getting these docs to elastic.co? |
Awesome! Sure can 🎉 |
OK, I pushed some changes that are required to build this PR locally. If
I'll add comments to this PR for content recommendations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's my first round of suggestions on the content.
I added a webhook for docs ci testing to this repo (hope that's ok!). It won't work correctly until elastic/docs#2010 is merged. |
@elasticmachine, run elasticsearch-ci/docs |
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
Thanks for the super quick and thorough review ❤️
I agree. What's the best way to do that? |
No prob!
I'll add another commit that adjusts the heading levels to match the proposed layout |
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
I like the aesthetics and how it makes the installation instructions more streamlined but it's a bit awkward that you can end up looking at the log4j2 instruction for adding a dependency and at the Logback instruction for the layout/encoder instructions. Or is it possible to synchronize the selection of a logger across all tabs? |
The selected tab is synched to all tab groups. You can play around with the functionality on this page to get a feel for it: https://www.elastic.co/guide/en/observability/7.10/ingest-logs.html |
Ah, nice! Then let's go for it! |
…s-logging into asciidoc-docs # Conflicts: # docs/setup-log4j2.asciidoc # docs/setup-logback.asciidoc
Nice! I've extracted the structured logging section into it's own page as it's not necessarily a step to get started but some advanced capabilities of the log4j2 logger that are interesting after getting started. |
Great call. That section was getting a bit long. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
closes #99