Skip to content

Convert docs to asciidoc #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 23, 2020
Merged

Conversation

felixbarny
Copy link
Member

@felixbarny felixbarny commented Nov 18, 2020

closes #99

@felixbarny felixbarny added documentation Improvements or additions to documentation agent-java labels Nov 18, 2020
@felixbarny felixbarny added this to the 1.0 milestone Nov 18, 2020
@apmmachine
Copy link
Contributor

apmmachine commented Nov 18, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #112 updated]

  • Start Time: 2020-11-23T07:50:17.721+0000

  • Duration: 8 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 127
Skipped 4
Total 131

@felixbarny
Copy link
Member Author

Hey @bmorelli25 could you help with getting these docs to elastic.co?

@bmorelli25
Copy link
Member

Awesome! Sure can 🎉

@bmorelli25
Copy link
Member

OK, I pushed some changes that are required to build this PR locally. If export GIT_HOME="/<fullPathTYourRepos>", you can build these docs with the following command:

$GIT_HOME/docs/build_docs --doc $GIT_HOME/ecs-logging-java/docs/index.asciidoc --chunk 1 --open

I'll add comments to this PR for content recommendations.

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my first round of suggestions on the content.

@bmorelli25
Copy link
Member

I added a webhook for docs ci testing to this repo (hope that's ok!). It won't work correctly until elastic/docs#2010 is merged.

@bmorelli25
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25
Copy link
Member

Sorry, last thing -- for now at least. What structure were you expecting? This is what we have right now:

Screen Shot 2020-11-18 at 1 13 33 PM

I think it makes sense for all of the setup pages to be sub-pages of the getting started topic.

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
@felixbarny
Copy link
Member Author

Thanks for the super quick and thorough review ❤️

I think it makes sense for all of the setup pages to be sub-pages of the getting started topic.

I agree. What's the best way to do that?

@felixbarny felixbarny changed the title Begin converting docs to asciidoc Convert docs to asciidoc Nov 19, 2020
@felixbarny felixbarny marked this pull request as ready for review November 19, 2020 07:01
@bmorelli25
Copy link
Member

bmorelli25 commented Nov 19, 2020

No prob!

I agree. What's the best way to do that?

I'll add another commit that adjusts the heading levels to match the proposed layout

@bmorelli25
Copy link
Member

I played around with this a bit more... what do you think of using tabs to display all installation options on one page? I'll screenshot an example below -- note that this isn't complete yet, just a prototype to give you an idea of what I'm talking about.
Screen Shot 2020-11-19 at 1 00 39 PM

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
@felixbarny
Copy link
Member Author

I like the aesthetics and how it makes the installation instructions more streamlined but it's a bit awkward that you can end up looking at the log4j2 instruction for adding a dependency and at the Logback instruction for the layout/encoder instructions. Or is it possible to synchronize the selection of a logger across all tabs?

@bmorelli25
Copy link
Member

The selected tab is synched to all tab groups. You can play around with the functionality on this page to get a feel for it: https://www.elastic.co/guide/en/observability/7.10/ingest-logs.html

@felixbarny
Copy link
Member Author

Ah, nice! Then let's go for it!

@bmorelli25
Copy link
Member

Here's where we're at now. Let me know your thoughts.

screencapture-localhost-8000-guide-setup-html-2020-11-20-12_55_30

@felixbarny
Copy link
Member Author

Nice! I've extracted the structured logging section into it's own page as it's not necessarily a step to get started but some advanced capabilities of the log4j2 logger that are interesting after getting started.

@bmorelli25
Copy link
Member

Great call. That section was getting a bit long.

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmorelli25 bmorelli25 merged commit 7ce3047 into elastic:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert documentation to asciidoc and publish on elastic.co
3 participants